Workaround for dpnp.linalg.qr() to run on CUDA#2265
Merged
vlad-perevezentsev merged 6 commits intomasterfrom Jan 20, 2025
Merged
Workaround for dpnp.linalg.qr() to run on CUDA#2265vlad-perevezentsev merged 6 commits intomasterfrom
dpnp.linalg.qr() to run on CUDA#2265vlad-perevezentsev merged 6 commits intomasterfrom
Conversation
vlad-perevezentsev
requested review from
AlexanderKalistratov,
antonwolfy and
vtavana
as code owners
antonwolfy
reviewed
Jan 17, 2025
antonwolfy
approved these changes
Jan 17, 2025
Contributor
antonwolfy
left a comment
antonwolfy
left a comment
There was a problem hiding this comment.
LGTM! Thank you @vlad-perevezentsev
antonwolfy
reviewed
Jan 17, 2025
Collaborator
Contributor
|
Array API standard conformance tests for dpnp=0.17.0dev4=py312he4f9c94_13 ran successfully. |
github-actions bot
added a commit
that referenced
this pull request
Jan 20, 2025
This PR suggests adding a workaround like waiting for host task after calling `geqrf` to avoid a race condition due to an issue in oneMath uxlfoundation/oneMath#626 Also updates tests by removing old skips and adds `test_qr_large` in `TestQr` 807179a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR suggests adding a workaround like waiting for host task after calling
geqrfto avoid a race condition due to an issue in oneMath uxlfoundation/oneMath#626Also updates tests by removing old skips and adds
test_qr_largeinTestQr